@matanl-starkware reviewed 9 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry).

crates/apollo_staking/src/contract_types.rs line 59 at r2 (raw file):

impl TryFromIterator<Felt> for ContractStaker {
    type Error = RetdataDeserializationError;
    fn try_from_iter<T: Iterator<Item = Felt>>(iter: &mut T) -> Result<Self, Self::Error> {

Worth adding a comment describing the how the Felts supposed to be when everything is OK

Code quote:

fn try_from_iter

crates/apollo_staking/src/contract_types.rs line 124 at r2 (raw file):

        })?;

        let mut result = Vec::new();

Reserve capacity

Code quote:

Vec::new()

crates/apollo_staking/src/contract_types.rs line 156 at r2 (raw file):

#[cfg(test)]
impl From<&Staker> for ContractStaker {

Why do we need the type Staker?

Code quote:

Staker

@dafnamatsry made 3 comments.
Reviewable status: 8 of 9 files reviewed, 2 unresolved discussions (waiting on @matanl-starkware).

crates/apollo_staking/src/contract_types.rs line 59 at r2 (raw file):

Done.

crates/apollo_staking/src/contract_types.rs line 124 at r2 (raw file):

Done.

crates/apollo_staking/src/contract_types.rs line 156 at r2 (raw file):

It simplifies the get_committee interface by removing the Option from public key.

@matanl-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry).

crates/apollo_staking/src/contract_types.rs line 156 at r2 (raw file):

OK
So lets add also From<&ContractStaker> for Staker

@dafnamatsry made 1 comment.
Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @matanl-starkware).

crates/apollo_staking/src/contract_types.rs line 156 at r2 (raw file):

Done.

@matanl-starkware reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry).

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry).